-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP exporter TLS integration test #4732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4732 +/- ##
==========================================
- Coverage 81.96% 81.93% -0.04%
==========================================
Files 313 313
Lines 12731 12731
==========================================
- Hits 10435 10431 -4
- Misses 2296 2300 +4 |
utpilla
reviewed
Aug 1, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/integration-test/docker-compose.yml
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Aug 1, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/integration-test/run-test.sh
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Aug 1, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/IntegrationTests.cs
Show resolved
Hide resolved
utpilla
reviewed
Aug 1, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/integration-test/.gitignore
Outdated
Show resolved
Hide resolved
…metry-dotnet into alanwest/otlp-tls-test
utpilla
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally added this test in #1795, but I guess I never merged it 😅, so reopening...
I believe this test may serve a foundation for the integration tests necessary in #4731.
It is limited to testing
net6.0/net7.0
, so it does not test the old Google gRPC library. We could consider manually testing things against the old library for now - especially since we are considering dropping that library.