Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP exporter TLS integration test #4732

Merged
merged 10 commits into from
Aug 1, 2023

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Jul 31, 2023

I originally added this test in #1795, but I guess I never merged it 😅, so reopening...

I believe this test may serve a foundation for the integration tests necessary in #4731.

It is limited to testing net6.0/net7.0, so it does not test the old Google gRPC library. We could consider manually testing things against the old library for now - especially since we are considering dropping that library.

@alanwest alanwest requested a review from a team July 31, 2023 19:59
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #4732 (e9e8600) into main (1979781) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4732      +/-   ##
==========================================
- Coverage   81.96%   81.93%   -0.04%     
==========================================
  Files         313      313              
  Lines       12731    12731              
==========================================
- Hits        10435    10431       -4     
- Misses       2296     2300       +4     

see 3 files with indirect coverage changes

@alanwest alanwest mentioned this pull request Jul 31, 2023
4 tasks
@utpilla utpilla merged commit 909e52d into open-telemetry:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants